From 115c57f829286f7391fdebde8e518b7ccef30e4f Mon Sep 17 00:00:00 2001 From: Joel Therrien Date: Tue, 22 Jan 2019 11:01:21 -0800 Subject: [PATCH] Improve documentation and add a `final` to MeanResponseCombiner. --- .../responses/regression/MeanResponseCombiner.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/java/ca/joeltherrien/randomforest/responses/regression/MeanResponseCombiner.java b/src/main/java/ca/joeltherrien/randomforest/responses/regression/MeanResponseCombiner.java index f7726a7..137c02c 100644 --- a/src/main/java/ca/joeltherrien/randomforest/responses/regression/MeanResponseCombiner.java +++ b/src/main/java/ca/joeltherrien/randomforest/responses/regression/MeanResponseCombiner.java @@ -21,16 +21,14 @@ import ca.joeltherrien.randomforest.tree.ResponseCombiner; import java.util.List; /** - * This implementation of the collector isn't great... but good enough given that I'm not planning to fully support regression trees. - * - * (It's not great because you'll lose accuracy as you sum up the doubles, since dividing by n is the very last step.) + * Returns the Mean value of a group of Doubles. * */ public class MeanResponseCombiner implements ResponseCombiner { @Override public Double combine(List responses) { - double size = responses.size(); + final double size = responses.size(); return responses.stream().mapToDouble(db -> db/size).sum();