joel/largeRCRF-Java
1
0
Fork 0
Code Issues 3 Pull requests Releases Wiki Activity

Fix incorrect use of non-concurrent Random object in NumericCovariate.

Browse source
This commit is contained in:
Joel Therrien 2018-07-04 12:18:27 -07:00
parent e0cfed632f
commit c7298f7da6
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/main/java/ca/joeltherrien/randomforest/NumericCovariate.java
View file

@ -17,18 +17,20 @@ public class NumericCovariate implements Covariate<Double>{
@Override
public Collection<NumericSplitRule> generateSplitRules(List<Value<Double>> data, int number) {
final Random random = ThreadLocalRandom.current();
// for this implementation we need to shuffle the data
final List<Value<Double>> shuffledData;
if(number > data.size()){
shuffledData = new ArrayList<>(data);
Collections.shuffle(shuffledData);
Collections.shuffle(shuffledData, random);
}
else{ // only need the top number entries
shuffledData = new ArrayList<>(number);
final Set<Integer> indexesToUse = new HashSet<>();
while(indexesToUse.size() < number){
final int index = ThreadLocalRandom.current().nextInt(data.size());
final int index = random.nextInt(data.size());
if(indexesToUse.add(index)){
shuffledData.add(data.get(index));