joel/privacy-friendly-sudoku-fork
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Change implementation of of ShareBoardDialogFragment to use databinding instead of 'findViewById'

Browse source
This commit is contained in:
uykek 2020-05-09 14:05:43 +02:00
parent 8f3371b38d
commit 4134013fe9
2 changed files with 17 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
app/src/main/java/org/secuso/privacyfriendlysudoku/ui/GameActivity.java
View file

@ -51,6 +51,7 @@ import org.secuso.privacyfriendlysudoku.ui.view.SudokuFieldLayout;
import org.secuso.privacyfriendlysudoku.ui.view.SudokuKeyboardLayout; import org.secuso.privacyfriendlysudoku.ui.view.SudokuKeyboardLayout;
import org.secuso.privacyfriendlysudoku.ui.view.SudokuSpecialButtonLayout; import org.secuso.privacyfriendlysudoku.ui.view.SudokuSpecialButtonLayout;
import org.secuso.privacyfriendlysudoku.ui.view.WinDialog; import org.secuso.privacyfriendlysudoku.ui.view.WinDialog;
import org.secuso.privacyfriendlysudoku.ui.view.databinding.DialogFragmentShareBoardBinding;
import java.util.LinkedList; import java.util.LinkedList;
import java.util.List; import java.util.List;
@ -302,11 +303,15 @@ public class GameActivity extends BaseActivity implements NavigationView.OnNavig
// remember to include alternate code for older android versions // remember to include alternate code for older android versions
String codeForClipboard = gameController.getFieldAsString().toString(); String codeForClipboard = gameController.getFieldAsString().toString();
ClipboardManager clipboard = (ClipboardManager) getSystemService(Context.CLIPBOARD_SERVICE); ClipboardManager clipboard = (ClipboardManager) getSystemService(Context.CLIPBOARD_SERVICE);
ClipData clip = ClipData.newPlainText("BoardCode", codeForClipboard);
clipboard.setPrimaryClip(clip);
Toast.makeText(GameActivity.this, R.string.copy_code_confirmation_toast, if (clipboard != null) {
Toast.LENGTH_LONG).show(); ClipData clip = ClipData.newPlainText("BoardCode", codeForClipboard);
clipboard.setPrimaryClip(clip);
Toast.makeText(GameActivity.this, R.string.copy_code_confirmation_toast,
Toast.LENGTH_LONG).show();
} else {
//
}
} }
}); });
shareDialog.show(getFragmentManager(), "ShareDialogFragment"); shareDialog.show(getFragmentManager(), "ShareDialogFragment");
@ -506,12 +511,11 @@ public class GameActivity extends BaseActivity implements NavigationView.OnNavig
AlertDialog.Builder builder = new AlertDialog.Builder(getActivity()); AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
LayoutInflater inflater = getActivity().getLayoutInflater(); LayoutInflater inflater = getActivity().getLayoutInflater();
View layout = inflater.inflate(R.layout.dialog_fragment_share_board, null); DialogFragmentShareBoardBinding binding = DialogFragmentShareBoardBinding.inflate(inflater);
TextView displayText = (TextView)layout.findViewById(R.id.ver3_display_sudoku_text_view); binding.ver3DisplaySudokuTextView.setText(displayCode);
displayText.setText(displayCode); binding.ver3CopySudokuToClipboardButton.setOnClickListener(copyClickListener);
((ImageButton)layout.findViewById(R.id.ver3_copy_sudoku_to_clipboard_button)).setOnClickListener(copyClickListener); builder.setView(binding.getRoot());
builder.setView(layout);
builder.setPositiveButton(R.string.share_confirmation_confirm, new DialogInterface.OnClickListener() { builder.setPositiveButton(R.string.share_confirmation_confirm, new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int id) { public void onClick(DialogInterface dialog, int id) {

7
app/src/main/res/layout/dialog_fragment_share_board.xml
View file

@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto">
<androidx.constraintlayout.widget.ConstraintLayout <androidx.constraintlayout.widget.ConstraintLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent"> android:layout_height="match_parent">
@ -38,4 +38,5 @@
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="@+id/ver3_copy_sudoku_to_clipboard_button" app:layout_constraintTop_toTopOf="@+id/ver3_copy_sudoku_to_clipboard_button"
app:layout_constraintVertical_bias="0.0" /> app:layout_constraintVertical_bias="0.0" />
</androidx.constraintlayout.widget.ConstraintLayout> </androidx.constraintlayout.widget.ConstraintLayout>
</layout>